fix(android): missing listener instance try catch#110
Merged
gladiuscode merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
3 tasks
📝 WalkthroughWalkthroughAdded exception handling to three emitter methods in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@android/src/main/java/com/orientationdirector/OrientationDirectorModule.kt`:
- Around line 52-57: The current methods (e.g., sendOnDeviceOrientationChanged)
swallow all Exceptions around emitOnDeviceOrientationChanged; instead create a
small helper like ensureReactContextActive(reactContext) or
hasActiveCatalystInstance() that checks the ReactContext/CatalystInstance is
non-null and active, call that guard before invoking
emitOnDeviceOrientationChanged (and the other send* methods on lines 60-65 and
68-73), remove the broad try/catch blocks, and if you want visibility log only
unexpected errors (Log.e or processLogger.error) when the guard succeeds and an
emission actually throws — do not catch Exception broadly or hide failures.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 75542ffa-7017-4e09-bda8-108e308590cc
📒 Files selected for processing (1)
android/src/main/java/com/orientationdirector/OrientationDirectorModule.kt
android/src/main/java/com/orientationdirector/OrientationDirectorModule.kt
Show resolved
Hide resolved
gladiuscode
deleted the
fix/109-android-crash-caused-by-nulled-eventemitter
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit